From: Hans de Goede Date: Tue, 21 May 2019 19:54:12 +0000 (+0200) Subject: staging: rtl8723bs: Fix Coverity warning in rtw_dbg_port() X-Git-Tag: Ubuntu-5.10.0-12.13~4988^2~423 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=99803f17ded0f2193e81cad9deddf318f4c34e4b;p=mirror_ubuntu-hirsute-kernel.git staging: rtl8723bs: Fix Coverity warning in rtw_dbg_port() Fix the following Coverity warning: File: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c in function rtw_dbg_port(): CID 18480: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) dead_error_condition: The condition (extra_arg & 7U) > 7U cannot be true. if ((extra_arg & 0x07) > 0x07) padapter->driver_ampdu_spacing = 0xFF; else padapter->driver_ampdu_spacing = extra_arg; Reported-by: Colin Ian King Signed-off-by: Hans de Goede Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 74a7328b5dd5..bfbbcf0bded3 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -3096,7 +3096,7 @@ static int rtw_dbg_port(struct net_device *dev, DBG_871X("enable driver ctrl ampdu density = %d\n", extra_arg); - if ((extra_arg & 0x07) > 0x07) + if (extra_arg > 0x07) padapter->driver_ampdu_spacing = 0xFF; else padapter->driver_ampdu_spacing = extra_arg;