From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 3 Dec 2018 14:52:01 +0000 (+0300)
Subject: clk: zynqmp: Off by one in zynqmp_is_valid_clock()
X-Git-Tag: Ubuntu-5.13.0-19.19~9639^2
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=9a43be9cedd516f188e6333d3b43402386723eff;p=mirror_ubuntu-jammy-kernel.git

clk: zynqmp: Off by one in zynqmp_is_valid_clock()

The > comparison should be >= to prevent reading beyond the end of the
clock[] array.

(The clock[] array is allocated in zynqmp_clk_setup() and has
clock_max_idx elements.)

Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---

diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c
index 297f16a20bfc..f65cc0ff76ab 100644
--- a/drivers/clk/zynqmp/clkc.c
+++ b/drivers/clk/zynqmp/clkc.c
@@ -128,7 +128,7 @@ static const struct zynqmp_eemi_ops *eemi_ops;
  */
 static inline int zynqmp_is_valid_clock(u32 clk_id)
 {
-	if (clk_id > clock_max_idx)
+	if (clk_id >= clock_max_idx)
 		return -ENODEV;
 
 	return clock[clk_id].valid;