From: Dmitry Torokhov Date: Fri, 14 Nov 2014 22:09:50 +0000 (-0300) Subject: [media] exynos4-is: fix error handling of irq_of_parse_and_map X-Git-Tag: Ubuntu-snapdragon-4.4.0-1050.54~9130^2~70 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=9a7a848df1995f05f750b4ed491ac80a459c912f;p=mirror_ubuntu-artful-kernel.git [media] exynos4-is: fix error handling of irq_of_parse_and_map Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c index 22162b2567da..3d49ce03b176 100644 --- a/drivers/media/platform/exynos4-is/fimc-is.c +++ b/drivers/media/platform/exynos4-is/fimc-is.c @@ -814,9 +814,9 @@ static int fimc_is_probe(struct platform_device *pdev) return -ENOMEM; is->irq = irq_of_parse_and_map(dev->of_node, 0); - if (is->irq < 0) { + if (!is->irq) { dev_err(dev, "no irq found\n"); - return is->irq; + return -EINVAL; } ret = fimc_is_get_clocks(is);