From: Coly Li Date: Fri, 28 Jun 2019 11:59:51 +0000 (+0800) Subject: bcache: set largest seq to ja->seq[bucket_index] in journal_read_bucket() X-Git-Tag: Ubuntu-5.10.0-12.13~5026^2~38 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=a231f07a5fe30a522b402011c5190cb936641a66;p=mirror_ubuntu-hirsute-kernel.git bcache: set largest seq to ja->seq[bucket_index] in journal_read_bucket() In journal_read_bucket() when setting ja->seq[bucket_index], there might be potential case that a later non-maximum overwrites a better sequence number to ja->seq[bucket_index]. This patch adds a check to make sure that ja->seq[bucket_index] will be only set a new value if it is bigger then current value. Signed-off-by: Coly Li Signed-off-by: Jens Axboe --- diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c index 98ee467ec3f7..3d321bffddc9 100644 --- a/drivers/md/bcache/journal.c +++ b/drivers/md/bcache/journal.c @@ -156,7 +156,8 @@ add: list_add(&i->list, where); ret = 1; - ja->seq[bucket_index] = j->seq; + if (j->seq > ja->seq[bucket_index]) + ja->seq[bucket_index] = j->seq; next_set: offset += blocks * ca->sb.block_size; len -= blocks * ca->sb.block_size;