From: Colin Ian King Date: Wed, 19 Aug 2020 16:01:03 +0000 (+0100) Subject: ASoC: qcom: add missing out of memory check on drvdata->clks allocation X-Git-Tag: Ubuntu-5.10.0-12.13~1487^2^2~172 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=a467f2f8ad5f9a21f92b3fa6ad2aac90fa7054fe;p=mirror_ubuntu-hirsute-kernel.git ASoC: qcom: add missing out of memory check on drvdata->clks allocation Currently drvdata->clks is not being checked for an allocation failure, leading to potential null pointer dereferencing. Fix this by adding a check and returning -ENOMEM if an error occurred. Fixes: 1220f6a76e77 ("ASoC: qcom: Add common array to initialize soc based core clocks") Signed-off-by: Colin Ian King Reviewed-by: Rohit kumar Addresses-Coverity: ("Dereference null return value") Link: https://lore.kernel.org/r/20200819160103.164893-1-colin.king@canonical.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c index dd9e3dd014f6..5c8ae225cd5d 100644 --- a/sound/soc/qcom/lpass-apq8016.c +++ b/sound/soc/qcom/lpass-apq8016.c @@ -168,6 +168,8 @@ static int apq8016_lpass_init(struct platform_device *pdev) drvdata->clks = devm_kcalloc(dev, variant->num_clks, sizeof(*drvdata->clks), GFP_KERNEL); + if (!drvdata->clks) + return -ENOMEM; drvdata->num_clks = variant->num_clks; for (i = 0; i < drvdata->num_clks; i++)