From: Gen Zhang Date: Wed, 29 May 2019 01:53:05 +0000 (+0800) Subject: wcd9335: fix a incorrect use of kstrndup() X-Git-Tag: Ubuntu-5.10.0-12.13~4757^2~7^2~424 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=a54988113985ca22e414e132054f234fc8a92604;p=mirror_ubuntu-hirsute-kernel.git wcd9335: fix a incorrect use of kstrndup() In wcd9335_codec_enable_dec(), 'widget_name' is allocated by kstrndup(). However, according to doc: "Note: Use kmemdup_nul() instead if the size is known exactly." So we should use kmemdup_nul() here instead of kstrndup(). Signed-off-by: Gen Zhang Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index a04a7cedd99d..85737fe54474 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -2734,7 +2734,7 @@ static int wcd9335_codec_enable_dec(struct snd_soc_dapm_widget *w, char *dec; u8 hpf_coff_freq; - widget_name = kstrndup(w->name, 15, GFP_KERNEL); + widget_name = kmemdup_nul(w->name, 15, GFP_KERNEL); if (!widget_name) return -ENOMEM;