From: Dave Jiang Date: Mon, 25 Jul 2016 17:34:03 +0000 (-0700) Subject: dmaengine: fsl_raid: move unmap to before callback X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~9270^2~1^2~3 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=a941106de4434c0173a2c6d5abedb2d1cfc11206;p=mirror_ubuntu-focal-kernel.git dmaengine: fsl_raid: move unmap to before callback Completion callback should happen after dma_descriptor_unmap() has happened. This allow the cache invalidate to happen and ensure that the data accessed by the upper layer is in memory that was from DMA rather than stale data. On some architecture this is done by the hardware, however we should make the code consistent to not cause confusion. Signed-off-by: Dave Jiang Cc: Xuelin Shi Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c index 35d017a50502..a8c8b9ebd5b4 100644 --- a/drivers/dma/fsl_raid.c +++ b/drivers/dma/fsl_raid.c @@ -135,8 +135,8 @@ static void fsl_re_issue_pending(struct dma_chan *chan) static void fsl_re_desc_done(struct fsl_re_desc *desc) { dma_cookie_complete(&desc->async_tx); - dmaengine_desc_get_callback_invoke(&desc->async_tx, NULL); dma_descriptor_unmap(&desc->async_tx); + dmaengine_desc_get_callback_invoke(&desc->async_tx, NULL); } static void fsl_re_cleanup_descs(struct fsl_re_chan *re_chan)