From: Imre Deak Date: Thu, 9 May 2019 17:34:41 +0000 (+0300) Subject: drm/i915: WARN for eDP encoders in intel_dp_detect_dpcd() X-Git-Tag: Ubuntu-5.13.0-19.19~8107^2~26^2~55 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=ad5125d6ef2de22212de82debd0baaecdaa7e7cd;p=mirror_ubuntu-jammy-kernel.git drm/i915: WARN for eDP encoders in intel_dp_detect_dpcd() We are not calling this function for eDP, so add an early assert about this for clarity. Cc: Ville Syrjälä Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20190509173446.31095-7-imre.deak@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 700ceacb82e6..1e011998e9d5 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -4844,15 +4844,15 @@ intel_dp_detect_dpcd(struct intel_dp *intel_dp) u8 *dpcd = intel_dp->dpcd; u8 type; + if (WARN_ON(intel_dp_is_edp(intel_dp))) + return connector_status_connected; + if (lspcon->active) lspcon_resume(lspcon); if (!intel_dp_get_dpcd(intel_dp)) return connector_status_disconnected; - if (intel_dp_is_edp(intel_dp)) - return connector_status_connected; - /* if there's no downstream port, we're done */ if (!drm_dp_is_branch(dpcd)) return connector_status_connected;