From: Sairam Venugopal <vsairam@vmware.com>
Date: Tue, 26 Feb 2019 22:53:35 +0000 (-0800)
Subject: datapath-windows: Fix race condition during port creation
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=adffc2f75ec41473fe6c96f69aed2385b642cc20;p=ovs.git

datapath-windows: Fix race condition during port creation

Hold the dispatch lock until port-add operations are completed.

Found by inspection.

Signed-off-by: Sairam Venugopal <vsairam@vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean@ovn.org>
Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
---

diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index e08cb90ce..bb83c2235 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath-windows/ovsext/Vport.c
@@ -452,12 +452,11 @@ HvConnectNic(POVS_SWITCH_CONTEXT switchContext,
     vport->ovsState = OVS_STATE_CONNECTED;
     vport->nicState = NdisSwitchNicStateConnected;
 
-    NdisReleaseRWLock(switchContext->dispatchLock, &lockState);
-
     if (nicParam->NicType == NdisSwitchNicTypeInternal) {
         OvsInternalAdapterUp(vport->portNo, &vport->netCfgInstanceId);
     }
 
+    NdisReleaseRWLock(switchContext->dispatchLock, &lockState);
 done:
     VPORT_NIC_EXIT(nicParam);
 }