From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Mon, 29 Feb 2016 06:49:50 +0000 (+0530)
Subject: greybus: hid: Don't disable connection-tx before destroying hid-device
X-Git-Tag: Ubuntu-5.13.0-19.19~14927^2~378^2~21^2~627
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=b22b7104d5930ed4aae2c8494b8f95f20a85d66b;p=mirror_ubuntu-jammy-kernel.git

greybus: hid: Don't disable connection-tx before destroying hid-device

hid_destroy_device() can potentially call callbacks defined in struct
hid_ll_driver, which may initiate few greybus operations.

And so connection (tx) should be kept enabled until the hid-device isn't
destroyed.

Reported-by: Jiss Kuruvila <jkuruvila@google.com>
Reported-by: Laurent Pinchart <laurent.pinchart@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
index 4db337cf7acc..601ee6fc81d5 100644
--- a/drivers/staging/greybus/hid.c
+++ b/drivers/staging/greybus/hid.c
@@ -490,8 +490,8 @@ static void gb_hid_disconnect(struct gb_bundle *bundle)
 {
 	struct gb_hid *ghid = greybus_get_drvdata(bundle);
 
-	gb_connection_disable(ghid->connection);
 	hid_destroy_device(ghid->hid);
+	gb_connection_disable(ghid->connection);
 	gb_connection_destroy(ghid->connection);
 	kfree(ghid);
 }