From: Hugh Daschbach Date: Thu, 21 Jan 2010 18:15:55 +0000 (-0800) Subject: [SCSI] libfc: Don't assume response request present. X-Git-Tag: Ubuntu-5.0.0-8.9~24237^2~3 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=b248df30fca3aeee1d650b570e8cbc4e8cc45710;p=mirror_ubuntu-disco-kernel.git [SCSI] libfc: Don't assume response request present. Fix NULL pointer dereference crash occurs in fc_lport_bsg_request() for bsg requests that do not contain a response request. Specifically, FC_BSG_HST_ADD_RPORT and FC_BSG_HST_DEL_RPORT bsg requests are not guaranteed to include a response request. Signed-off-by: Hugh Daschbach Signed-off-by: Robert Love Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c index 0b165024a219..7ec8ce75007c 100644 --- a/drivers/scsi/libfc/fc_lport.c +++ b/drivers/scsi/libfc/fc_lport.c @@ -1800,7 +1800,8 @@ int fc_lport_bsg_request(struct fc_bsg_job *job) u32 did; job->reply->reply_payload_rcv_len = 0; - rsp->resid_len = job->reply_payload.payload_len; + if (rsp) + rsp->resid_len = job->reply_payload.payload_len; mutex_lock(&lport->lp_mutex);