From: David Howells <dhowells@redhat.com>
Date: Tue, 13 Sep 2016 21:36:22 +0000 (+0100)
Subject: rxrpc: Add missing unlock in rxrpc_call_accept()
X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~9295^2~187^2~5
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=b25de3605339c94a6c27d42efe8f7748ea206a8b;p=mirror_ubuntu-focal-kernel.git

rxrpc: Add missing unlock in rxrpc_call_accept()

Add a missing unlock in rxrpc_call_accept() in the path taken if there's no
call to wake up.

Signed-off-by: David Howells <dhowells@redhat.com>
---

diff --git a/net/rxrpc/call_accept.c b/net/rxrpc/call_accept.c
index b8acec0d596e..06e328f6b0f0 100644
--- a/net/rxrpc/call_accept.c
+++ b/net/rxrpc/call_accept.c
@@ -425,9 +425,11 @@ struct rxrpc_call *rxrpc_accept_call(struct rxrpc_sock *rx,
 
 	write_lock(&rx->call_lock);
 
-	ret = -ENODATA;
-	if (list_empty(&rx->to_be_accepted))
-		goto out;
+	if (list_empty(&rx->to_be_accepted)) {
+		write_unlock(&rx->call_lock);
+		kleave(" = -ENODATA [empty]");
+		return ERR_PTR(-ENODATA);
+	}
 
 	/* check the user ID isn't already in use */
 	pp = &rx->calls.rb_node;