From: Daniel Imms <tyriar@tyriar.com>
Date: Sat, 6 May 2017 00:40:23 +0000 (-0700)
Subject: Clean up
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=b36d8780fded65320f308aff6039097123dd4652;p=mirror_xterm.js.git

Clean up
---

diff --git a/src/SelectionManager.ts b/src/SelectionManager.ts
index df9294b..4d4533f 100644
--- a/src/SelectionManager.ts
+++ b/src/SelectionManager.ts
@@ -39,18 +39,25 @@ export class SelectionManager {
   }
 
   private _onTrim(amount: number) {
+    // TODO: Somehow map the selection coordinates with the list that is constantly being trimmed
+    //       Maybe we need an ID in the CircularList that starts from 0 for the first entry and increments
     console.log('trimmed: ' + amount);
   }
 
+  private _getMouseBufferCoords(event: MouseEvent) {
+    // TODO: Take into account the current terminal viewport when fetching coordinates
+    return Mouse.getCoords(event, this._rowContainer, this._charMeasure);
+  }
+
   private _onMouseDown(event: MouseEvent) {
-    this._selectionStart = Mouse.getCoords(event, this._rowContainer, this._charMeasure);
+    this._selectionStart = this._getMouseBufferCoords(event);
     if (this._selectionStart) {
       this._rowContainer.addEventListener('mousemove', this._mouseMoveListener);
     }
   }
 
   private _onMouseMove(event: MouseEvent) {
-    this._selectionEnd = Mouse.getCoords(event, this._rowContainer, this._charMeasure);
+    this._selectionEnd = this._getMouseBufferCoords(event);
   }
 
   private _onMouseUp(event: MouseEvent) {