From: Paul Moore Date: Thu, 6 Dec 2012 05:48:38 +0000 (+0000) Subject: tun: correctly report an error in tun_flow_init() X-Git-Tag: v4.13~10531^2~57 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=b3943aef7ecfcc47609136f46773e9a839c950b0;p=mirror_ubuntu-bionic-kernel.git tun: correctly report an error in tun_flow_init() On error, the error code from tun_flow_init() is lost inside tun_set_iff(), this patch fixes this by assigning the tun_flow_init() error code to the "err" variable which is returned by the tun_flow_init() function on error. Signed-off-by: Paul Moore Acked-by: Jason Wang Signed-off-by: David S. Miller --- diff --git a/drivers/net/tun.c b/drivers/net/tun.c index a1b2389e6d7f..14a04543cd91 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1591,7 +1591,8 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr) tun_net_init(dev); - if (tun_flow_init(tun)) + err = tun_flow_init(tun); + if (err < 0) goto err_free_dev; dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST |