From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 12 Jul 2006 20:29:56 +0000 (-0700)
Subject: [IPV4]: Fix error handling for fib_insert_node call
X-Git-Tag: Ubuntu-5.13.0-19.19~56074^2~6
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=b47b2ec19892ffc2b06ebf138ed4aa141275a1c2;p=mirror_ubuntu-jammy-kernel.git

[IPV4]: Fix error handling for fib_insert_node call

The error handling around fib_insert_node was broken because we always
zeroed the error before checking it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 1cb65305e102..23fb9d9768e3 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -1252,8 +1252,8 @@ fn_trie_insert(struct fib_table *tb, struct rtmsg *r, struct kern_rta *rta,
 	 */
 
 	if (!fa_head) {
-		fa_head = fib_insert_node(t, &err, key, plen);
 		err = 0;
+		fa_head = fib_insert_node(t, &err, key, plen);
 		if (err)
 			goto out_free_new_fa;
 	}