From: Samuel Mannehed <samuel@cendio.se>
Date: Thu, 25 Aug 2016 13:32:15 +0000 (+0200)
Subject: Fix window close warning
X-Git-Tag: v1.0.0~278
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=b9efece4a8b896a533cfd456098246011dc35f84;p=mirror_novnc.git

Fix window close warning

The code didn't follow current API for the beforeunload event.
---

diff --git a/include/ui.js b/include/ui.js
index ae2fdb6..058ae5a 100644
--- a/include/ui.js
+++ b/include/ui.js
@@ -156,11 +156,17 @@ var UI;
 
             Util.addEvent(window, 'load', UI.keyboardinputReset);
 
+            // While connected we want to display a confirmation dialogue
+            // if the user tries to leave the page
             Util.addEvent(window, 'beforeunload', function () {
                 if (UI.rfb && UI.rfb_state === 'normal') {
-                    return "You are currently connected.";
+                    var msg = "You are currently connected.";
+                    e.returnValue = msg;
+                    return msg;
+                else {
+                    return void 0; // To prevent the dialogue when disconnected
                 }
-            } );
+            });
 
             // Show description by default when hosted at for kanaka.github.com
             if (location.host === "kanaka.github.io") {