From: Dan Carpenter Date: Sat, 30 Mar 2013 10:53:54 +0000 (+0200) Subject: usb: chipidea: fix precedence bug in ci_requests_show() X-Git-Tag: Ubuntu-5.0.0-8.9~13898^2~91 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=ba8618e067907407ec84001adc11bc1f184d19a6;p=mirror_ubuntu-disco-kernel.git usb: chipidea: fix precedence bug in ci_requests_show() The intent here was to have parenthesis around the (ci->hw_ep_max / 2) so that it counts like "0 1 2 0 1 2". In the current code, the mod operation happens first so it counts like "0 0 1 1 2 2". Signed-off-by: Dan Carpenter [rebased on top of debug.c changes] Signed-off-by: Alexander Shishkin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c index 5738079734e3..36a7063a6cba 100644 --- a/drivers/usb/chipidea/debug.c +++ b/drivers/usb/chipidea/debug.c @@ -175,7 +175,7 @@ static int ci_requests_show(struct seq_file *s, void *data) req = list_entry(ptr, struct ci13xxx_req, queue); seq_printf(s, "EP=%02i: TD=%08X %s\n", - i % ci->hw_ep_max/2, (u32)req->dma, + i % (ci->hw_ep_max / 2), (u32)req->dma, ((i < ci->hw_ep_max/2) ? "RX" : "TX")); for (j = 0; j < qsize; j++)