From: Dan Carpenter Date: Wed, 26 Jun 2013 07:52:20 +0000 (+0300) Subject: ALSA: ak4xx-adda: info leak in ak4xxx_capture_source_info() X-Git-Tag: Ubuntu-5.13.0-19.19~21963^2~3^2~9 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=bd5fe738e388ceaa32e5171481e0d3ec59f0ccfe;p=mirror_ubuntu-jammy-kernel.git ALSA: ak4xx-adda: info leak in ak4xxx_capture_source_info() "idx" is controled by the user and can be a negative offset into the input_names[] array. Signed-off-by: Dan Carpenter Signed-off-by: Takashi Iwai --- diff --git a/sound/i2c/other/ak4xxx-adda.c b/sound/i2c/other/ak4xxx-adda.c index cef813d23641..ed726d1569e8 100644 --- a/sound/i2c/other/ak4xxx-adda.c +++ b/sound/i2c/other/ak4xxx-adda.c @@ -571,7 +571,7 @@ static int ak4xxx_capture_source_info(struct snd_kcontrol *kcontrol, struct snd_akm4xxx *ak = snd_kcontrol_chip(kcontrol); int mixer_ch = AK_GET_SHIFT(kcontrol->private_value); const char **input_names; - int num_names, idx; + unsigned int num_names, idx; num_names = ak4xxx_capture_num_inputs(ak, mixer_ch); if (!num_names)