From: Colin Ian King <colin.king@canonical.com>
Date: Mon, 2 Sep 2019 09:40:52 +0000 (+0100)
Subject: staging: exfat: remove return and error return via a goto
X-Git-Tag: Ubuntu-5.10.0-12.13~4520^2~70
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=be22bc7ceb5f4a713924c2ccaa9db1c27992b739;p=mirror_ubuntu-hirsute-kernel.git

staging: exfat: remove return and error return via a goto

The return statement is incorrect, the error exit should be by
assigning ret with the error code and exiting via label out.
Thanks to Valdis Klētnieks for correcting my original fix.

Addresses-Coverity: ("Structurally dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190902094052.28029-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index aaebd40ee6f3..881cd85cf677 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -670,7 +670,7 @@ static int ffsLookupFile(struct inode *inode, char *path, struct file_id_t *fid)
 	dentry = p_fs->fs_func->find_dir_entry(sb, &dir, &uni_name, num_entries,
 					       &dos_name, TYPE_ALL);
 	if (dentry < -1) {
-		return FFS_NOTFOUND;
+		ret = FFS_NOTFOUND;
 		goto out;
 	}