From: Jacob Keller Date: Tue, 16 Jun 2015 20:39:11 +0000 (-0700) Subject: fm10k: use an unsigned int for i in ethtool_get_strings X-Git-Tag: v4.13~5024^2~53^2~10 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=c0e58e93d722a53aa26b18110389c8131af9ddd9;p=mirror_ubuntu-bionic-kernel.git fm10k: use an unsigned int for i in ethtool_get_strings The value will never be negative, and we use the %u print format. Thus, use unsigned int for the loop counter. Issue found using cppcheck. Signed-off-by: Jacob Keller Signed-off-by: Jeff Kirsher --- diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c index 4b9d9f88af70..06f0b08d9af5 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c @@ -124,7 +124,7 @@ static void fm10k_get_strings(struct net_device *dev, u32 stringset, u8 *data) { struct fm10k_intfc *interface = netdev_priv(dev); char *p = (char *)data; - int i; + unsigned int i; switch (stringset) { case ETH_SS_TEST: