From: Kai-Heng Feng Date: Wed, 11 Mar 2020 06:13:28 +0000 (+0800) Subject: ALSA: hda/realtek: Fix pop noise on ALC225 X-Git-Tag: Ubuntu-4.15.0-97.98~119 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=c13c807c4ad2587bb1278ec4dc194bec671bd9cb;p=mirror_ubuntu-bionic-kernel.git ALSA: hda/realtek: Fix pop noise on ALC225 BugLink: https://bugs.launchpad.net/bugs/1870604 commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757 upstream. Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") makes the ALC225 have pop noise on S3 resume and cold boot. So partially revert this commit for ALC225 to fix the regression. Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") BugLink: https://bugs.launchpad.net/bugs/1866357 Signed-off-by: Kai-Heng Feng Link: https://lore.kernel.org/r/20200311061328.17614-1-kai.heng.feng@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman Signed-off-by: Kamal Mostafa Signed-off-by: Khalid Elmously --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 88a48d4e2ec3..0b7166379ea3 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -327,6 +327,8 @@ static void alc_fill_eapd_coef(struct hda_codec *codec) alc_update_coef_idx(codec, 0x4, 1<<15, 0); break; case 0x10ec0225: + codec->power_save_node = 1; + /* fall through */ case 0x10ec0295: case 0x10ec0299: alc_update_coef_idx(codec, 0x67, 0xf000, 0x3000);