From: Dominik Csapak <d.csapak@proxmox.com>
Date: Mon, 23 Oct 2017 13:01:12 +0000 (+0200)
Subject: jslint: if needs a block
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=c17f9fe4d0e3cd390cd39bc2630999cf237bd3b1;p=pmg-gui.git

jslint: if needs a block

single statements after if can be confusing

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

diff --git a/js/ClusterAdministration.js b/js/ClusterAdministration.js
index d1a2ff3..f59c101 100644
--- a/js/ClusterAdministration.js
+++ b/js/ClusterAdministration.js
@@ -247,7 +247,9 @@ Ext.define('PMG.ClusterAdministration', {
 		    renderer: function(value, metaData, record) {
 			var d = record.data;
 			var state = 'active';
-			if (!d.insync) state = 'syncing';
+			if (!d.insync) {
+			    state = 'syncing';
+			}
 			if (d.conn_error) {
 			    metaData.tdCls = 'x-form-invalid-field';
 			    var html = '<p>' +  Ext.htmlEncode(d.conn_error) + '</p>';
diff --git a/js/LoginView.js b/js/LoginView.js
index 7de8082..af2e80a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -11,7 +11,9 @@ Ext.define('PMG.LoginView', {
 
 	    var realmfield = me.lookup('realmfield');
 
-	    if (view.targetview !== 'quarantineview') return;
+	    if (view.targetview !== 'quarantineview') {
+		return;
+	    }
 
 	    realmfield.setValue('quarantine');
 
diff --git a/js/PostfixMailQueue.js b/js/PostfixMailQueue.js
index d757309..101a43b 100644
--- a/js/PostfixMailQueue.js
+++ b/js/PostfixMailQueue.js
@@ -32,7 +32,9 @@ Ext.define('PMG.Postfix.MailQueue', {
 	xclass: 'Ext.app.ViewController',
 
 	init: function(view) {
-	    if (view.nodename) view.setNodename(view.nodename);
+	    if (view.nodename) {
+		view.setNodename(view.nodename);
+	    }
 
 	    view.delayFilterTask = new Ext.util.DelayedTask(function() {
 		var filter = view.lookupReference('filter').getValue();
@@ -170,7 +172,9 @@ Ext.define('PMG.Postfix.MailQueue', {
     updateProxy: function() {
 	var me = this;
 
-	if (me.pendingLoad) return;
+	if (me.pendingLoad) {
+	    return;
+	}
 
 	var proxy = {
 	    type: 'proxmox',
diff --git a/js/PostfixQShape.js b/js/PostfixQShape.js
index 2f0b073..3fa88ae 100644
--- a/js/PostfixQShape.js
+++ b/js/PostfixQShape.js
@@ -34,7 +34,9 @@ Ext.define('PMG.Postfix.QShape', {
 	xclass: 'Ext.app.ViewController',
 
 	init: function(view) {
-	    if (view.nodename) view.setNodename(view.nodename);
+	    if (view.nodename) {
+		view.setNodename(view.nodename);
+	    }
 	},
 
 	onFlush: function() {
diff --git a/js/StatStore.js b/js/StatStore.js
index ec83780..a5e94e9 100644
--- a/js/StatStore.js
+++ b/js/StatStore.js
@@ -33,8 +33,9 @@ Ext.define('PMG.data.StatStore', {
 
 	var last = me.proxy.extraParams;
 
-	if (last.starttime === ts.starttime && last.endtime === ts.endtime)
+	if (last.starttime === ts.starttime && last.endtime === ts.endtime) {
 	    return; // avoid repeated loads
+	}
 
 	me.proxy.url = me.staturl;
 	me.proxy.extraParams = { starttime: ts.starttime, endtime: ts.endtime };
diff --git a/js/SystemConfiguration.js b/js/SystemConfiguration.js
index 741d54b..2c816fe 100644
--- a/js/SystemConfiguration.js
+++ b/js/SystemConfiguration.js
@@ -15,7 +15,9 @@ Ext.define('PMG.RestoreSystemConfiguration', {
 		gettext('Confirm'),
 		gettext('Reset rule database to factory defaults?'),
 		function(button) {
-		    if (button !== 'yes') return;
+		    if (button !== 'yes') {
+			return;
+		    }
 		    var url = '/config/ruledb';
 		    Proxmox.Utils.API2Request({
 			url: '/config/ruledb',
diff --git a/js/UserBlackWhiteList.js b/js/UserBlackWhiteList.js
index 7255b6b..523bd17 100644
--- a/js/UserBlackWhiteList.js
+++ b/js/UserBlackWhiteList.js
@@ -65,7 +65,9 @@ Ext.define('PMG.UserBlackWhiteList', {
 	onRemoveAddress: function() {
 	    var me = this.getView();
 	    var rec = me.selModel.getSelection()[0];
-	    if (!rec) return;
+	    if (!rec) {
+		return;
+	    }
 
 	    var params = me.getStore().getProxy().getExtraParams() || {};
 	    var url = '/quarantine/' + me.listname + '/' + rec.getId();
diff --git a/js/ViewMailHeaders.js b/js/ViewMailHeaders.js
index c4059f2..f3cd4ba 100644
--- a/js/ViewMailHeaders.js
+++ b/js/ViewMailHeaders.js
@@ -34,11 +34,17 @@ Ext.define('PMG.ViewMailHeaders', {
 		success: function(response, opts) {
 		    var data = response.result.data;
 		    var from = data.match(/^FROM:\s*(.*\S)\s*$/mi);
-		    if (from) view.lookupReference('fromField').setValue(from[1]);
+		    if (from) {
+			view.lookupReference('fromField').setValue(from[1]);
+		    }
 		    var to = data.match(/^TO:\s*(.*\S)\s*$/mi);
-		    if (to) view.lookupReference('toField').setValue(to[1]);
+		    if (to) {
+			view.lookupReference('toField').setValue(to[1]);
+		    }
 		    var subject = data.match(/^SUBJECT:\s*(.*\S)\s*$/mi);
-		    if (subject) view.lookupReference('subjectField').setValue(subject[1]);
+		    if (subject) {
+			view.lookupReference('subjectField').setValue(subject[1]);
+		    }
 		    panel.update(Ext.String.htmlEncode(data));
 		},
 		failure: function (response, opts) {