From: Joel Porquet <joel@porquet.org>
Date: Mon, 26 May 2014 16:07:38 +0000 (+0200)
Subject: staging: silicom/bypasslib/bp_ioctl.h: Fix erroneous global variable definitions
X-Git-Tag: Ubuntu-snapdragon-4.4.0-1029.32~8292^2~39^2~187
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=c1ad28a3995da1e8300d29ac01fd3757c8dfadfc;p=mirror_ubuntu-zesty-kernel.git

staging: silicom/bypasslib/bp_ioctl.h: Fix erroneous global variable definitions

Originally, this header was defining two new typedefs, CMND_TYPE and
CMND_TYPE_SD, following this type of declaration:

typedef enum {
	...
} CMND_TYPE;

A previous commit (785086556a573f07747b3633732a9dbd7e45728f) tried to
fix warnings that were pointed out by checkpatch.pl, concerning not
adding new typedefs. But this commit only removed the 'typedef' keyword,
thus transforming both the typedefs into two the definition of global
variables. For example:

enum {
	...
} CMND_TYPE;

As noticed by the Sparse tool, this patch removes those erroneous global
variable definitions, and just leaves anonymous enum type definitions:

enum {
	...
};

Signed-off-by: Joel Porquet <joel@porquet.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/silicom/bypasslib/bp_ioctl.h b/drivers/staging/silicom/bypasslib/bp_ioctl.h
index bf47f786866b..a13932af733b 100644
--- a/drivers/staging/silicom/bypasslib/bp_ioctl.h
+++ b/drivers/staging/silicom/bypasslib/bp_ioctl.h
@@ -101,7 +101,7 @@ enum {
 	SET_BP_WAIT_AT_PWUP,
 	GET_BP_HW_RESET,
 	SET_BP_HW_RESET,
-} CMND_TYPE;
+};
 
 enum {
 	IF_SCAN_SD,
@@ -154,7 +154,7 @@ enum {
 	GET_BP_HW_RESET_SD,
 	SET_BP_HW_RESET_SD,
 
-} CMND_TYPE_SD;
+};
 
 #define SIOCGIFBYPASS (SIOCDEVPRIVATE+10)