From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Tue, 19 Oct 2021 07:33:37 +0000 (+0200)
Subject: tools: getxattr: document how to get actual argument size
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=c1e4c83ceb0453620333b1fdbafb8b463af0f937;p=pve-common.git

tools: getxattr: document how to get actual argument size

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 2f248da..c17198d 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -1865,7 +1865,7 @@ sub mount($$$$$) {
 }
 
 # size is optional and defaults to 256, note that xattr limits are FS specific and that xattrs can
-# get arbitrary long. NOTE: $! is set to ENOBUFS if the xattr is longer than the buffer size used.
+# get arbitrary long. pass `0` for $size in array context to get the actual size of a value
 sub getxattr($$;$) {
     my ($path_or_handle, $name, $size) = @_;
     $size //= 256;
@@ -1879,8 +1879,6 @@ sub getxattr($$;$) {
     }
     if ($xattr_size < 0) {
 	return undef;
-    } elsif ($xattr_size > $size) {
-	$! = POSIX::ENOBUFS;
     }
     return wantarray ? ($buf, $xattr_size) : $buf;
 }