From: Douglas Anderson Date: Mon, 22 Jul 2019 18:24:38 +0000 (-0700) Subject: drm: panel-lvds: Spout an error if of_get_display_timing() gives an error X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~2016^2~18^2~92 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=c2d7e47ad190189213b3e01956a6b5055ba8de24;p=mirror_ubuntu-focal-kernel.git drm: panel-lvds: Spout an error if of_get_display_timing() gives an error In the patch ("video: of: display_timing: Don't yell if no timing node is present") we'll stop spouting an error directly in of_get_display_timing() if no node is present. Presumably panel-lvds should take charge of spouting its own error now. NOTE: we'll print two errors if the node was present but there were problems parsing the timing node (one in of_parse_display_timing() and this new one). Since this is a fatal error for the driver's probe (and presumably someone will be debugging), this should be OK. Signed-off-by: Douglas Anderson Reviewed-by: Sam Ravnborg Cc: Thierry Reding Cc: David Airlie Cc: Philipp Zabel Cc: Tomi Valkeinen Cc: Laurent Pinchart Cc: Russell King Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnierkiewicz Link: https://patchwork.freedesktop.org/patch/msgid/20190722182439.44844-4-dianders@chromium.org --- diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 1ec57d0806a8..ad47cc95459e 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -147,8 +147,11 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) int ret; ret = of_get_display_timing(np, "panel-timing", &timing); - if (ret < 0) + if (ret < 0) { + dev_err(lvds->dev, "%pOF: problems parsing panel-timing (%d)\n", + np, ret); return ret; + } videomode_from_timing(&timing, &lvds->video_mode);