From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 30 Mar 2012 11:20:21 +0000 (+0200)
Subject: usb-ehci: drop assert()
X-Git-Tag: v1.1-rc0~91^2
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=c7020c974073ba9c0110d45361720a29ff6b2f59;p=qemu.git

usb-ehci: drop assert()

Not sure what the purpose of the assert() was, in any case it is bogous.
We can arrive there if transfer descriptors passed to us from the guest
failed to pass sanity checks, i.e. it is guest-triggerable.  We deal
with that case by resetting the host controller.  Everything is ok, no
need to throw a core dump here.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---

diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index e12f09870..23631a47c 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2009,7 +2009,6 @@ static void ehci_advance_state(EHCIState *ehci,
             fprintf(stderr, "processing error - resetting ehci HC\n");
             ehci_reset(ehci);
             again = 0;
-            assert(0);
         }
     }
     while (again);