From: Markus Elfring Date: Wed, 12 Oct 2016 07:51:29 +0000 (-0300) Subject: [media] DaVinci-VPBE: Return the success indication only as a constant in vpbe_set_mode() X-Git-Tag: Ubuntu-4.10.0-19.21~1964^2^2~300 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=ca7948aa85290f55b8929a8c028352913167bca3;p=mirror_ubuntu-artful-kernel.git [media] DaVinci-VPBE: Return the success indication only as a constant in vpbe_set_mode() * Return a success code without storing it in an intermediate variable. * Delete the local variable "ret" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c index 3ac4ba35832a..50b9e3df68b5 100644 --- a/drivers/media/platform/davinci/vpbe.c +++ b/drivers/media/platform/davinci/vpbe.c @@ -509,7 +509,6 @@ static int vpbe_set_mode(struct vpbe_device *vpbe_dev, struct v4l2_dv_timings dv_timings; struct osd_state *osd_device; int out_index = vpbe_dev->current_out_index; - int ret = 0; int i; if (!mode_info || !mode_info->name) @@ -549,8 +548,7 @@ static int vpbe_set_mode(struct vpbe_device *vpbe_dev, vpbe_dev->current_timings.upper_margin); mutex_unlock(&vpbe_dev->lock); - - return ret; + return 0; } static int vpbe_set_default_mode(struct vpbe_device *vpbe_dev)