From: Johan Hovold Date: Thu, 24 Nov 2016 18:21:30 +0000 (+0100) Subject: net: fsl/fman: fix fixed-link-phydev reference leak X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~8927^2~54^2~1 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=cb1f3410ff12520b22fa03ccd23892c360de0c26;p=mirror_ubuntu-focal-kernel.git net: fsl/fman: fix fixed-link-phydev reference leak Make sure to drop the reference taken by of_phy_find_device() when looking up a fixed-link phydev during probe. Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Johan Hovold Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 8fe6b3e253fa..736db9d9b0ad 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -892,6 +892,8 @@ static int mac_probe(struct platform_device *_of_dev) priv->fixed_link->duplex = phy->duplex; priv->fixed_link->pause = phy->pause; priv->fixed_link->asym_pause = phy->asym_pause; + + put_device(&phy->mdio.dev); } err = mac_dev->init(mac_dev);