From: Julian Braha Date: Mon, 17 Jan 2022 04:09:40 +0000 (+0100) Subject: ARM: 9178/1: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE X-Git-Tag: Ubuntu-5.15.0-27.28~47 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=ce97c5e0cef26fddebcf5dd6fe0fb07b87f3686c;p=mirror_ubuntu-jammy-kernel.git ARM: 9178/1: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE BugLink: https://bugs.launchpad.net/bugs/1966057 [ Upstream commit 11c57c3ba94da74c3446924260e34e0b1950b5d7 ] Resending this to properly add it to the patch tracker - thanks for letting me know, Arnd :) When ARM is enabled, and BITREVERSE is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for HAVE_ARCH_BITREVERSE Depends on [n]: BITREVERSE [=n] Selected by [y]: - ARM [=y] && (CPU_32v7M [=n] || CPU_32v7 [=y]) && !CPU_32v6 [=n] This is because ARM selects HAVE_ARCH_BITREVERSE without selecting BITREVERSE, despite HAVE_ARCH_BITREVERSE depending on BITREVERSE. This unmet dependency bug was found by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha Signed-off-by: Russell King (Oracle) Signed-off-by: Sasha Levin Signed-off-by: Paolo Pisati --- diff --git a/lib/Kconfig b/lib/Kconfig index 5e7165e6a346..fa4b10322efc 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -45,7 +45,6 @@ config BITREVERSE config HAVE_ARCH_BITREVERSE bool default n - depends on BITREVERSE help This option enables the use of hardware bit-reversal instructions on architectures which support such operations.