From: Stoiko Ivanov <s.ivanov@proxmox.com>
Date: Fri, 26 May 2023 16:48:02 +0000 (+0200)
Subject: buildsys: use simple parenthesis for variables
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=d2fd5726838ce62986361e2640a47ee2070566dc;p=libxdgmime-perl.git

buildsys: use simple parenthesis for variables

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---

diff --git a/Makefile b/Makefile
index ce027dd..1af13ad 100644
--- a/Makefile
+++ b/Makefile
@@ -3,57 +3,57 @@ include /usr/share/dpkg/architecture.mk
 
 PACKAGE=libxdgmime-perl
 
-DEB = ${PACKAGE}_${DEB_VERSION_UPSTREAM_REVISION}_${DEB_BUILD_ARCH}.deb
-DSC = ${PACKAGE}_${DEB_VERSION_UPSTREAM_REVISION}.dsc
-BUILDSRC=${PACKAGE}-${DEB_VERSION_UPSTREAM}
+DEB = $(PACKAGE)_$(DEB_VERSION_UPSTREAM_REVISION)_$(DEB_BUILD_ARCH).deb
+DSC = $(PACKAGE)_$(DEB_VERSION_UPSTREAM_REVISION).dsc
+BUILDSRC=$(PACKAGE)-$(DEB_VERSION_UPSTREAM)
 
 OPKGNAME=Xdgmime
 UPSTREAM=xdgmime-source/src
 
-all: ${DEB}
+all: $(DEB)
 .PHONY: update-bindings
 update-bindings:
-	cp -a ${UPSTREAM}/xdgmime*.[ch] ${OPKGNAME}/
-	h2xs -P -v ${DEB_VERSION_UPSTREAM} -F -DHAVE_MMAP -M '^XDG_' -t PV -Ofan Xdgmime xdgmime.h
-	rm -f ${OPKGNAME}/xdgmime*.[ch]
+	cp -a $(UPSTREAM)/xdgmime*.[ch] $(OPKGNAME)/
+	h2xs -P -v $(DEB_VERSION_UPSTREAM) -F -DHAVE_MMAP -M '^XDG_' -t PV -Ofan Xdgmime xdgmime.h
+	rm -f $(OPKGNAME)/xdgmime*.[ch]
 	echo "Please manually check and add the diff of the automatically generated update"
 
-.PHONY: ${BUILDSRC}
-${BUILDSRC}:
-	-rm -rf ${BUILDSRC}
-	cp -a ${OPKGNAME} ${BUILDSRC}
-	cp -a ${UPSTREAM}/xdgmime*.[ch] ${BUILDSRC}/
-	perl -MDevel::PPPort -e 'Devel::PPPort::WriteFile("${BUILDSRC}/ppport.h");'
-	cp -a debian ${BUILDSRC}
+.PHONY: $(BUILDSRC)
+$(BUILDSRC):
+	-rm -rf $(BUILDSRC)
+	cp -a $(OPKGNAME) $(BUILDSRC)
+	cp -a $(UPSTREAM)/xdgmime*.[ch] $(BUILDSRC)/
+	perl -MDevel::PPPort -e 'Devel::PPPort::WriteFile("$(BUILDSRC)/ppport.h");'
+	cp -a debian $(BUILDSRC)
 
 .PHONY: dsc
-dsc: ${DSC}
-${DSC}: ${BUILDSRC}
-	cd ${BUILDSRC}; dpkg-buildpackage -S -us -uc -d -nc
-	lintian ${DSC}
+dsc: $(DSC)
+$(DSC): $(BUILDSRC)
+	cd $(BUILDSRC); dpkg-buildpackage -S -us -uc -d -nc
+	lintian $(DSC)
 
 .PHONY: sbuild
 sbuild: $(DSC)
 	sbuild $(DSC)
 
 .PHONY: deb
-deb: ${DEB}
-${DEB}: ${OPKGNAME}/Xdgmime.xs ${BUILDSRC}
-	cd ${BUILDSRC}; dpkg-buildpackage -b -us -uc
-	lintian ${DEB}
+deb: $(DEB)
+$(DEB): $(OPKGNAME)/Xdgmime.xs $(BUILDSRC)
+	cd $(BUILDSRC); dpkg-buildpackage -b -us -uc
+	lintian $(DEB)
 
 .phony: upload
-upload: UPLOAD_DIST ?= ${DEB_DISTRIBUTION}
-upload: ${DEB}
-	tar cf - ${DEB} | ssh -X repoman@repo.proxmox.com -- upload --product pmg --dist ${UPLOAD_DIST}
+upload: UPLOAD_DIST ?= $(DEB_DISTRIBUTION)
+upload: $(DEB)
+	tar cf - $(DEB) | ssh -X repoman@repo.proxmox.com -- upload --product pmg --dist $(UPLOAD_DIST)
 
 
-CLEANFILES = *~ debian/*~ *.deb ${BUILDSRC} libxdgmime-perl* *.buildinfo *.build *.dsc *tar.?z
+CLEANFILES = *~ debian/*~ *.deb $(BUILDSRC) libxdgmime-perl* *.buildinfo *.build *.dsc *tar.?z
 
 .PHONY: clean
 clean: 
-	rm -rf ${CLEANFILES}
+	rm -rf $(CLEANFILES)
 
 .PHONY: dinstall
-dinstall: ${DEB}
-	dpkg -i ${DEB}
+dinstall: $(DEB)
+	dpkg -i $(DEB)