From: Nikolay Borisov <nborisov@suse.com>
Date: Mon, 18 Mar 2019 15:45:18 +0000 (+0200)
Subject: btrfs: Remove unused -EIO assignment in end_bio_extent_readpage
X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~2996^2~197
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=d51f51bb6f3c11f3ee4120c35de8e6547ed493fc;p=mirror_ubuntu-focal-kernel.git

btrfs: Remove unused -EIO assignment in end_bio_extent_readpage

In case we hit the error case for a metadata buffer in
end_bio_extent_readpage then 'ret' won't really be checked before it's
written again to. This means the -EIO in this case will never be
checked, just remove it.

Fixes-coverity-id: 1442513
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 9901e8127e0f..d0b8ed2c2631 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2614,8 +2614,6 @@ static void end_bio_extent_readpage(struct bio *bio)
 			if (test_and_clear_bit(EXTENT_BUFFER_READAHEAD,
 					       &eb->bflags))
 				btree_readahead_hook(eb, -EIO);
-
-			ret = -EIO;
 		}
 readpage_ok:
 		if (likely(uptodate)) {