From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Wed, 21 Apr 2021 12:19:50 +0000 (+0200)
Subject: ceph: pool: make min_size constrain check more general
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=d6f749e645bcf6385a6ba1de0b7abafd6607e743;p=pve-manager-legacy.git

ceph: pool: make min_size constrain check more general

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 9645431d..67863966 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -79,17 +79,18 @@ Ext.define('PVE.CephPoolInputPanel', {
 	    maxValue: 7,
 	    allowBlank: false,
 	    listeners: {
-		change: function(field, val) {
-		    let warn = true;
-		    let warn_text = gettext('Min. Size');
+		change: function(field, minSize) {
+		    let panel = field.up('inputpanel');
+		    let size = panel.down('field[name=size]').getValue();
 
-		    if (val < 2) {
-			warn = false;
-			warn_text = gettext('Min. Size') + ' <i class="fa fa-exclamation-triangle warning"></i>';
-		    }
+		    let showWarning = minSize <= size / 2 && minSize !== size;
 
-		    field.up().down('field[name=min_size-warning]').setHidden(warn);
-		    field.setFieldLabel(warn_text);
+		    let fieldLabel = gettext('Min. Size');
+		    if (showWarning) {
+			fieldLabel = gettext('Min. Size') + ' <i class="fa fa-exclamation-triangle warning"></i>';
+		    }
+		    panel.down('field[name=min_size-warning]').setHidden(!showWarning);
+		    field.setFieldLabel(fieldLabel);
 		},
 	    },
 	},
@@ -97,7 +98,7 @@ Ext.define('PVE.CephPoolInputPanel', {
 	    xtype: 'displayfield',
 	    name: 'min_size-warning',
 	    userCls: 'pmx-hint',
-	    value: 'A pool with min_size=1 could lead to data loss, incomplete PGs or unfound objects.',
+	    value: gettext('min_size <= size/2 can lead to data loss, incomplete PGs or unfound objects.'),
 	    hidden: true,
 	},
 	{