From: Oliver Neukum <oliver@neukum.org>
Date: Sat, 27 Feb 2010 19:55:26 +0000 (+0100)
Subject: usb: cdc-wdm: Fix race between disconnect and debug messages
X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~26569^2~19
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=d855fe2e9c19edaa47baba0e7f95e17f7a24dba8;p=mirror_ubuntu-focal-kernel.git

usb: cdc-wdm: Fix race between disconnect and debug messages

dev_dbg() and dev_err() cannot be used to report failures
that may have been caused by a device's removal

Signed-off-by: Oliver Neukum <neukum@b1-systems.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
index 940b17af162c..72e2eb030459 100644
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -435,11 +435,8 @@ retry:
 		spin_lock_irq(&desc->iuspin);
 
 		if (desc->rerr) { /* read completed, error happened */
-			int t = desc->rerr;
 			desc->rerr = 0;
 			spin_unlock_irq(&desc->iuspin);
-			dev_err(&desc->intf->dev,
-				"reading had resulted in %d\n", t);
 			rv = -EIO;
 			goto err;
 		}
@@ -477,8 +474,6 @@ retry:
 
 err:
 	mutex_unlock(&desc->lock);
-	if (rv < 0 && rv != -EAGAIN)
-		dev_err(&desc->intf->dev, "wdm_read: exit error\n");
 	return rv;
 }