From: Javier Martinez Canillas Date: Wed, 19 Aug 2015 11:19:56 +0000 (+0200) Subject: mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers X-Git-Tag: Ubuntu-snapdragon-4.4.0-1029.32~5969^2~8 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=da935c0b6eeeac16de0a82cc1152fb0a9b5a11ef;p=mirror_ubuntu-zesty-kernel.git mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers The ChromeOS EC SPI and I2C transport drivers depends on CROS_EC_PROTO but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends on is bad practice as it may lead to circular Kconfig dependencies. Since these drivers already depend on MFD_CROS_EC and that config option already selects CROS_EC_PROTO, there is no need to make them explicitly depend on CROS_EC_PROTO since that dependency is already met. Signed-off-by: Javier Martinez Canillas Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 93837b4e8025..dd55c25fb656 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -105,7 +105,7 @@ config MFD_CROS_EC config MFD_CROS_EC_I2C tristate "ChromeOS Embedded Controller (I2C)" - depends on MFD_CROS_EC && CROS_EC_PROTO && I2C + depends on MFD_CROS_EC && I2C help If you say Y here, you get support for talking to the ChromeOS @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C config MFD_CROS_EC_SPI tristate "ChromeOS Embedded Controller (SPI)" - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI + depends on MFD_CROS_EC && SPI ---help--- If you say Y here, you get support for talking to the ChromeOS EC