From: hujianyang Date: Wed, 21 May 2014 09:19:45 +0000 (+0800) Subject: UBIFS: Fix dump messages in ubifs_dump_lprops X-Git-Tag: Ubuntu-snapdragon-4.4.0-1050.54~10205^2~6 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=dac3698147655aba4d71a8e67d6dd46d7a86154f;p=mirror_ubuntu-artful-kernel.git UBIFS: Fix dump messages in ubifs_dump_lprops Function ubifs_read_one_lp will not set @lp and returns an error when ubifs_read_one_lp failed. We should not perform ubifs_dump_lprop in this case because @lp is not initialized as we wanted. Signed-off-by: hujianyang Signed-off-by: Artem Bityutskiy --- diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 5157b866a853..177b0152fef4 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -745,8 +745,10 @@ void ubifs_dump_lprops(struct ubifs_info *c) for (lnum = c->main_first; lnum < c->leb_cnt; lnum++) { err = ubifs_read_one_lp(c, lnum, &lp); - if (err) + if (err) { ubifs_err("cannot read lprops for LEB %d", lnum); + continue; + } ubifs_dump_lprop(c, &lp); }