From: Friedrich Weber <f.weber@proxmox.com>
Date: Mon, 13 Mar 2023 12:56:25 +0000 (+0100)
Subject: fix: api: fix permission check for cloudinit drive update
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=dafabbd01fa2612b7d28a7bc5c6bf876259309f8;p=qemu-server.git

fix: api: fix permission check for cloudinit drive update

Trying to regenerate a cloudinit drive as a non-root user via the API
currently throws a Perl error, as reported in the forum [1]. This is
due to a type mismatch in the permission check, where a string is
passed but an array is expected.

[1] https://forum.proxmox.com/threads/regenerate-cloudinit-by-put-api-return-500.124099/

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 030b3bad..1cff80b6 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1482,7 +1482,7 @@ __PACKAGE__->register_method({
     proxyto => 'node',
     description => "Regenerate and change cloudinit config drive.",
     permissions => {
-	check => ['perm', '/vms/{vmid}', 'VM.Config.Cloudinit'],
+	check => ['perm', '/vms/{vmid}', ['VM.Config.Cloudinit']],
     },
     parameters => {
 	additionalProperties => 0,