From: wang xiaofeng <winggundum82@163.com>
Date: Fri, 13 May 2016 03:20:28 +0000 (+0800)
Subject: PcAtChipsetPkg AcpiTimerLib: Fix a logic error
X-Git-Tag: edk2-stable201903~7054
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=dde4aedc35ee3c06b67c1a5c4f392e7a0b0f8254;p=mirror_edk2.git

PcAtChipsetPkg AcpiTimerLib: Fix a logic error

if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) &
EnableMask) != EnableMask)) {

The bracket place is not right, I think it should be

if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) &
EnableMask) != EnableMask)

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: wang xiaofeng <winggundum82@163.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---

diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c
index ad855fe4f5..806a4f7ce2 100644
--- a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c
+++ b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c
@@ -89,7 +89,7 @@ AcpiTimerLibConstructor (
   //
   // If ACPI I/O space is not enabled yet, program ACPI I/O base address and enable it.
   //
-  if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) & EnableMask) != EnableMask)) {
+  if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) & EnableMask) != EnableMask) {
     PciWrite16 (
       PCI_LIB_ADDRESS (Bus, Device, Function, PcdGet16 (PcdAcpiIoPciBarRegisterOffset)),
       PcdGet16 (PcdAcpiIoPortBaseAddress)