From: Bjorn Helgaas Date: Mon, 14 Sep 2009 22:35:05 +0000 (-0600) Subject: PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation X-Git-Tag: v4.13~22073^2~7 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=dffb4bb560ed73937a52c68c304b232c743b49f7;p=mirror_ubuntu-bionic-kernel.git PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation decode_hpp() looks up hotplug PCI parameters from ACPI and saves them in the acpiphp_bridge structure. These parameters (in bridge->hpp) are only used by the acpiphp_set_hpp_values() -> program_hpp() path. In that path, we always call decode_hpp() before program_hpp(), so there's no need to do it in init_bridge_misc(). Signed-off-by: Bjorn Helgaas Reviewed-by: Alex Chiang Reviewed-by: Kenji Kaneshige Acked-by: Kenji Kaneshige Signed-off-by: Jesse Barnes --- diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 680c33635b6f..e0623373615f 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -300,9 +300,6 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge) { acpi_status status; - /* decode ACPI 2.0 _HPP (hot plug parameters) */ - decode_hpp(bridge); - /* must be added to the list prior to calling register_slot */ list_add(&bridge->list, &bridge_list);