From: Dan Carpenter <error27@gmail.com>
Date: Sat, 6 Mar 2010 01:11:38 +0000 (+0000)
Subject: ems_usb: cleanup: remove uneeded check
X-Git-Tag: Ubuntu-5.0.0-8.9~23682^2~48
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=ea3fb371b2a391958670f2a65e1203f7dba61671;p=mirror_ubuntu-disco-kernel.git

ems_usb: cleanup: remove uneeded check

"skb" is alway non-null here, but even if it were null the check isn't
needed because dev_kfree_skb() can handle it.

This eliminates a smatch warning about dereferencing a variable before
checking that it is non-null.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index 11c87840cc00..33451092b8e8 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -876,9 +876,7 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
 	return NETDEV_TX_OK;
 
 nomem:
-	if (skb)
-		dev_kfree_skb(skb);
-
+	dev_kfree_skb(skb);
 	stats->tx_dropped++;
 
 	return NETDEV_TX_OK;