From: Leon Romanovsky <leonro@mellanox.com>
Date: Mon, 20 May 2019 06:54:19 +0000 (+0300)
Subject: rds: Don't check return value from destroy CQ
X-Git-Tag: Ubuntu-5.13.0-19.19~8105^2~176
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=eaa1ca9cf99224a57852f339bfbf058fbeadcb79;p=mirror_ubuntu-jammy-kernel.git

rds: Don't check return value from destroy CQ

There is no value in checking ib_destroy_cq() result and skipping to clear
struct ic fields. This connection needs to be reinitialized anyway.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---

diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index 66c6eb56072b..5a42ebb892cd 100644
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -611,11 +611,11 @@ send_hdrs_dma_out:
 qp_out:
 	rdma_destroy_qp(ic->i_cm_id);
 recv_cq_out:
-	if (!ib_destroy_cq(ic->i_recv_cq))
-		ic->i_recv_cq = NULL;
+	ib_destroy_cq(ic->i_recv_cq);
+	ic->i_recv_cq = NULL;
 send_cq_out:
-	if (!ib_destroy_cq(ic->i_send_cq))
-		ic->i_send_cq = NULL;
+	ib_destroy_cq(ic->i_send_cq);
+	ic->i_send_cq = NULL;
 rds_ibdev_out:
 	rds_ib_remove_conn(rds_ibdev, conn);
 out: