From: Christoph Hellwig <hch@lst.de>
Date: Sat, 23 Jul 2011 15:36:38 +0000 (+0200)
Subject: 9p: do no return 0 from ->check_acl without actually checking
X-Git-Tag: Ubuntu-5.13.0-19.19~26731^2~7
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=ebbb0ef2871bf3f529987313a9146cc42419a8a8;p=mirror_ubuntu-jammy-kernel.git

9p: do no return 0 from ->check_acl without actually checking

If we do not want to use ACLs we at least need to perform normal Unix
permission checks.  From the comment I'm not quite sure that's what
is intended, but if 0p wants to do permission checks entirely on the
server it needs to do so in ->permission, not in ->check_acl.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/9p/acl.c b/fs/9p/acl.c
index 8be87857605c..df4d7a171d7f 100644
--- a/fs/9p/acl.c
+++ b/fs/9p/acl.c
@@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask)
 		 * On access = client  and acl = on mode get the acl
 		 * values from the server
 		 */
-		return 0;
+		return -EAGAIN;
 	}
 	acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);