From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Date: Fri, 19 May 2017 12:05:19 +0000 (-0300)
Subject: [media] s2255drv: avoid a switch fall through
X-Git-Tag: Ubuntu-5.4-5.4.0-11.14~7501^2~325
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=ec33fbd585f76b0803a90ee66804fa6f937dccaa;p=mirror_ubuntu-focal-kernel.git

[media] s2255drv: avoid a switch fall through

On this driver, it can fall through a switch. I tried to
annotate it, in order to shut up a gcc warning, but that
didn't work, as the logic there is somewhat complex.

So, instead, let's just repeat the code. gcc should likely
optimize it anyway, and this makes the code better readable,
IMHO.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---

diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c
index a9d4484f7626..6a88b1dbb3a0 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -1803,6 +1803,8 @@ static int save_frame(struct s2255_dev *dev, struct s2255_pipeinfo *pipe_info)
 				default:
 					pr_info("s2255 unknown resp\n");
 				}
+				pdata++;
+				break;
 			default:
 				pdata++;
 				break;