From: Lorenzo Bianconi Date: Fri, 5 Jan 2018 17:52:00 +0000 (+0100) Subject: OVN: remove useless ds_clear() on actions ds X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=eddb84a1646c07c7c8ca5f5f147f4231273c235e;p=ovs.git OVN: remove useless ds_clear() on actions ds Remove ds_clear() on actions dynamic string in build_acls() since they have just been initialized to DS_EMPTY_INITIALIZER Signed-off-by: Lorenzo Bianconi Signed-off-by: Ben Pfaff --- diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index e3ddc1fd9..63ed97efb 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -3272,7 +3272,6 @@ build_acls(struct ovn_datapath *od, struct hmap *lflows) "(!ct.est || (ct.est && ct_label.blocked == 1)) " "&& (%s)", acl->match); - ds_clear(&actions); build_acl_log(&actions, acl); ds_put_cstr(&actions, "/* drop */"); ovn_lflow_add_with_hint(lflows, od, stage, @@ -3307,7 +3306,6 @@ build_acls(struct ovn_datapath *od, struct hmap *lflows) /* There are no stateful ACLs in use on this datapath, * so a "drop" ACL is simply the "drop" logical flow action * in all cases. */ - ds_clear(&actions); build_acl_log(&actions, acl); ds_put_cstr(&actions, "/* drop */"); ovn_lflow_add_with_hint(lflows, od, stage,