From: Artem Bityutskiy Date: Tue, 3 Jul 2012 13:43:27 +0000 (+0300) Subject: fs/sysv: remove another useless write_super call X-Git-Tag: Ubuntu-5.0.0-8.9~15634^2~24 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=eee458936b52bd3a9ff0ff577313b637905fff08;p=mirror_ubuntu-disco-kernel.git fs/sysv: remove another useless write_super call We do not need to call 'sysv_write_super()' from 'sysv_remount()', because VFS has called 'sysv_sync_fs()' before calling '->remount()'. So remove it. Remove also '(un)lock_super()' which obvioulsy is becoming useless in this function. Signed-off-by: Artem Bityutskiy Signed-off-by: Al Viro --- diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index af13d1342f23..f20ffe32b398 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c @@ -68,12 +68,9 @@ static void sysv_write_super(struct super_block *sb) static int sysv_remount(struct super_block *sb, int *flags, char *data) { struct sysv_sb_info *sbi = SYSV_SB(sb); - lock_super(sb); + if (sbi->s_forced_ro) *flags |= MS_RDONLY; - if (*flags & MS_RDONLY) - sysv_write_super(sb); - unlock_super(sb); return 0; }