From: Richard Hughes Date: Mon, 6 Feb 2023 15:00:49 +0000 (+0000) Subject: analogix: Do not check the endpoints before selecting an interface X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=eff7bfed8ec5f565bcff37c5ca402b4e86260a12;p=fwupd.git analogix: Do not check the endpoints before selecting an interface My Analogix USB device has a Billboard interface, with bNumEndpoints=0. When emulating the interface is NULL, and in runtime the array can *never* be NULL, so I think this check was added in error. --- diff --git a/plugins/analogix/fu-analogix-device.c b/plugins/analogix/fu-analogix-device.c index bbfe18ae2..5c69d6e94 100644 --- a/plugins/analogix/fu-analogix-device.c +++ b/plugins/analogix/fu-analogix-device.c @@ -208,11 +208,6 @@ fu_analogix_device_find_interface(FuUsbDevice *device, GError **error) if (g_usb_interface_get_class(intf) == BILLBOARD_CLASS && g_usb_interface_get_subclass(intf) == BILLBOARD_SUBCLASS && g_usb_interface_get_protocol(intf) == BILLBOARD_PROTOCOL) { - g_autoptr(GPtrArray) endpoints = NULL; - - endpoints = g_usb_interface_get_endpoints(intf); - if (endpoints == NULL) - continue; fu_usb_device_add_interface(FU_USB_DEVICE(self), g_usb_interface_get_number(intf)); return TRUE;