From: Steve French <smfrench@gmail.com>
Date: Fri, 27 Mar 2015 00:23:20 +0000 (-0500)
Subject: Don't ignore errors on encrypting password in SMBTcon
X-Git-Tag: Ubuntu-5.10.0-12.13~15083^2~6
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=f3a31a2bbbfe22db0313a4e270c7ba91baa7b630;p=mirror_ubuntu-hirsute-kernel.git

Don't ignore errors on encrypting password in SMBTcon

Although unlikely to fail (and tree connect does not commonly send
a password since SECMODE_USER is the default for most servers)
do not ignore errors on SMBNTEncrypt in SMB Tree Connect.

Reported by Coverity (CID 1226853)

Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 4cb8450e081b..cdb1aaf295b1 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3696,6 +3696,12 @@ CIFSTCon(const unsigned int xid, struct cifs_ses *ses,
 #endif /* CIFS_WEAK_PW_HASH */
 		rc = SMBNTencrypt(tcon->password, ses->server->cryptkey,
 					bcc_ptr, nls_codepage);
+		if (rc) {
+			cifs_dbg(FYI, "%s Can't generate NTLM rsp. Error: %d\n",
+				 __func__, rc);
+			cifs_buf_release(smb_buffer);
+			return rc;
+		}
 
 		bcc_ptr += CIFS_AUTH_RESP_SIZE;
 		if (ses->capabilities & CAP_UNICODE) {