From: Wolfram Sang Date: Wed, 19 Jul 2017 08:27:51 +0000 (+0200) Subject: watchdog: renesas_wdt: avoid (theoretical) type overflow X-Git-Tag: v4.14~325^2~28 X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=f6159dd4b085ad839ab02c1ba230535c53ef60d4;p=mirror_ubuntu-bionic-kernel.git watchdog: renesas_wdt: avoid (theoretical) type overflow Because the smallest clock divider we can select is 1, 'clks_per_sec' must be the same type as 'rate'. Signed-off-by: Wolfram Sang Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck --- diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c index cf61c92f7ecd..22b0348826de 100644 --- a/drivers/watchdog/renesas_wdt.c +++ b/drivers/watchdog/renesas_wdt.c @@ -37,7 +37,7 @@ struct rwdt_priv { void __iomem *base; struct watchdog_device wdev; struct clk *clk; - unsigned int clks_per_sec; + unsigned long clks_per_sec; u8 cks; }; @@ -112,8 +112,7 @@ static int rwdt_probe(struct platform_device *pdev) { struct rwdt_priv *priv; struct resource *res; - unsigned long rate; - unsigned int clks_per_sec; + unsigned long rate, clks_per_sec; int ret, i; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);