From: Namjae Jeon <linkinjeon@kernel.org>
Date: Wed, 1 Dec 2021 01:12:39 +0000 (+0900)
Subject: ksmbd: fix uninitialized symbol 'pntsd_size'
X-Git-Tag: Ubuntu-5.15.0-16.16~51
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=f7918593d08977ad279eb78fdf0b311e8810ef6a;p=mirror_ubuntu-jammy-kernel.git

ksmbd: fix uninitialized symbol 'pntsd_size'

BugLink: https://bugs.launchpad.net/bugs/1956305

commit f2e78affc48dee29b989c1d9b0d89b503dcd1204 upstream.

No check for if "rc" is an error code for build_sec_desc().
This can cause problems with using uninitialized pntsd_size.

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org # v5.15
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
---

diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index ad0ea5d36f2e..54a3ffa58198 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -2964,6 +2964,10 @@ int smb2_open(struct ksmbd_work *work)
 							    &pntsd_size, &fattr);
 					posix_acl_release(fattr.cf_acls);
 					posix_acl_release(fattr.cf_dacls);
+					if (rc) {
+						kfree(pntsd);
+						goto err_out;
+					}
 
 					rc = ksmbd_vfs_set_sd_xattr(conn,
 								    user_ns,