From: Colin Ian King <colin.king@canonical.com>
Date: Fri, 27 Jan 2017 15:00:25 +0000 (+0000)
Subject: net: ethernet: aquantia: remove another redundant err check
X-Git-Tag: v4.13~1282^2~296
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=f81e5ca9155e8b4527662aa66ba984f58257ccdb;p=mirror_ubuntu-bionic-kernel.git

net: ethernet: aquantia: remove another redundant err check

The check on err < 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398318 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index b517b2670a71..817c145520c8 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -304,8 +304,6 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
 
 		buff = NULL;
 	}
-	if (err < 0)
-		goto err_exit;
 
 err_exit:
 	if (err < 0) {