From: Ivan Bornyakov <brnkv.i1@gmail.com>
Date: Fri, 25 May 2018 17:49:52 +0000 (+0300)
Subject: atm: zatm: fix memcmp casting
X-Git-Tag: Ubuntu-5.10.0-12.13~7786^2~18
X-Git-Url: https://git.proxmox.com/?a=commitdiff_plain;h=f9c6442a8f0b1dde9e755eb4ff6fa22bcce4eabc;p=mirror_ubuntu-hirsute-kernel.git

atm: zatm: fix memcmp casting

memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One
can lose significant bits and get 0 from non-0 value returned by the
memcmp().

Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c
index 9c9a22958717..a8d2eb0ceb8d 100644
--- a/drivers/atm/zatm.c
+++ b/drivers/atm/zatm.c
@@ -1151,8 +1151,8 @@ static void eprom_get_byte(struct zatm_dev *zatm_dev, unsigned char *byte,
 }
 
 
-static unsigned char eprom_try_esi(struct atm_dev *dev, unsigned short cmd,
-				   int offset, int swap)
+static int eprom_try_esi(struct atm_dev *dev, unsigned short cmd, int offset,
+			 int swap)
 {
 	unsigned char buf[ZEPROM_SIZE];
 	struct zatm_dev *zatm_dev;